Minor bug fix: remove modal- click of close button#217
Open
harshith-venkatesh wants to merge 3 commits intoRealDevSquad:developfrom
Open
Minor bug fix: remove modal- click of close button#217harshith-venkatesh wants to merge 3 commits intoRealDevSquad:developfrom
harshith-venkatesh wants to merge 3 commits intoRealDevSquad:developfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@harshith-venkatesh is attempting to deploy a commit to the RCal Team on Vercel. A member of the Team first needs to authorize it. |
iRohitGaur
reviewed
Oct 2, 2023
This comment was marked as resolved.
This comment was marked as resolved.
| className={`w-full h-full duration-500 ease-out transition-all inset-0 absolute bg-gray-900 ${ | ||
| isDrawerVisible ? 'opacity-50' : 'opacity-0' | ||
| }`} | ||
| onClick={toggleDrawer} |
Contributor
Author
There was a problem hiding this comment.
I have added the click action here, could you ensure you have taken the latest pull
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Hi @harshith-venkatesh my bad, it didnt take the latest pull. I got the latest pull but found another issue. See the rec:
Untitled.mov
Contributor
Author
There was a problem hiding this comment.
Oh wow, I shouldn't have committed this mistake, thanks for the great review. Let me do the required changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
User was able to close the modal on click of anywhere in the screen thus leading to a new glitch of modal being observed with no data to display as well.
The changes have ensured to close the modal on click of the button only
Is it bug?
*Dev Tested?
*Tested on:
Platforms
Browsers
Before / After Change Screenshots